License Agreement
WebRTC welcomes patches/pulls for features and bug fixes!
For contributors external to Google, follow the instructions given in the Google Individual Contributor License Agreement. In all cases, contributors must sign a contributor license agreement before a contribution can be accepted. Please complete the agreement for an individual or a corporation as appropriate.
Contributing samples
If you plan to add a new sample or make significant changes to an existing sample, we recommend that you start by creating a new issue where we can discuss the details.
When creating a new sample or updating an existing one, please make sure you also create, or update any existing, tests. All tests in that repository are implemented as Nightwatch.JS UI tests, so please follow the same design in your own.
Instructions
Contributing your First Patch
You must do some preparation in order to upload your first CL:
- Check out and build the code
- Fill in the Contributor agreement (see above)
- If you’ve never submitted code before, you must add your (or your organization’s in the case the contributor agreement is signed by your organization) name and contact info to the AUTHORS file
- Go to
https://webrtc.googlesource.com/new-password
and login with your email account. This should be the same account as
returned by
git config user.email - Then, run:
git cl creds-check. If you get any errors, ask for help on discuss-webrtc
You will not have to repeat the above. After all that, you’re ready to upload:
Uploading your First Patch
Now that you have your account set up, you can do the actual upload:
Do this:
- Assuming you're on the main branch:
git checkout -b my-work-branch
Make changes, build locally, run tests locally
git commit -am "Changed x, and it is working"git cl upload
This will open a text editor showing all local commit messages, allowing you to modify it before it becomes the CL description.
Fill out the bug entry properly. Please specify the issue tracker prefix and the issue number, separated by a colon, e.g.
webrtc:123orchromium:12345. If you do not have an issue tracker prefix and an issue number just addNone.Save and close the file to proceed with the upload to the WebRTC code review server.
The command will print a link like https://webrtc-review.googlesource.com/c/src/+/53121. if everything goes well.
- Assuming you're on the main branch:
Click this CL Link
If you’re not signed in, click the Sign In button in the top right and sign in with your email
Click Start Review and add a reviewer. You can find reviewers in OWNERS files around the repository (take the one closest to your changes)
Address any reviewer feedback:
- Make changes, build locally, run tests locally
git commit -am "Fixed X and Y"git cl upload
- Make changes, build locally, run tests locally
Once the reviewer LGTMs (approves) the patch, ask them to put it into the commit queue
NOTICE: On Windows, you’ll need to run the above in a Git bash shell in order
for gclient to find the .gitcookies file.
Trybots
If you're working a lot in WebRTC, you can apply for try rights. This means you can run the trybots, which run all the tests on all platforms. To do this, file a bug on bugs.webrtc.org and ask for the EngProd team to grant you try rights.
To run a tryjob, upload a CL as described above and click either CQ dry run or Choose Trybots in the Gerrit UI. You need to have try rights for this. Otherwise, ask your reviewer to kick off the bots for you.